Skip to content

Swift: Strip out more unknown clang arguments#22013

Merged
jketema merged 2 commits into
github:mainfrom
jketema:swift/more-arguments
Jun 22, 2026
Merged

Swift: Strip out more unknown clang arguments#22013
jketema merged 2 commits into
github:mainfrom
jketema:swift/more-arguments

Conversation

@jketema

@jketema jketema commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the Swift label Jun 19, 2026
@jketema jketema marked this pull request as ready for review June 19, 2026 11:52
@jketema jketema requested a review from a team as a code owner June 19, 2026 11:52
Copilot AI review requested due to automatic review settings June 19, 2026 11:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Swift tracing configuration to strip two additional Clang warning flags that may be unrecognized by the configured Clang/Xcode toolchain, helping avoid build/extraction failures due to version mismatches.

Changes:

  • Strip -Werror=allocator-wrappers when passed to Clang via -Xcc.
  • Strip -Wno-error=allocator-wrappers when passed to Clang via -Xcc.
Show a summary per file
File Description
swift/tools/tracing-config.lua Adds two more strip_unsupported_clang_arg entries for allocator-wrappers warning flags.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread swift/tools/tracing-config.lua Outdated

@IdrissRio IdrissRio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cause of the problem is clear from the linked error.
LGTM 👍

@jketema jketema merged commit 03187ae into github:main Jun 22, 2026
25 checks passed
@jketema jketema deleted the swift/more-arguments branch June 22, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants